This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: PATCH: PR x86_64/584: Detect call on protected symbol


On Thu, Jan 20, 2005 at 12:05:44AM +0100, Jakub Jelinek wrote:
> On Wed, Jan 19, 2005 at 02:48:34PM -0800, H. J. Lu wrote:
> > X86_64 uses R_X86_64_PC32 for both branch and store/load. Linker
> > can't tell if a protected symbol reference is local or global just
> > by relocation. This patch disassembles the code to check for call.
> 
> Eh, why you need the disassembler there?
> Isn't it enough just to check if R_X86_64_PC32's r_offset > 0 and
> contents[r_offset - 1] == 0xe8?

Can we be sure that contents[r_offset - 1] == 0xe8 will be call?


H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]