This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: i386 intel syntax integer load/store fp instructions
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Jan Beulich <JBeulich at novell dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Thu, 21 Oct 2004 21:13:30 +0930
- Subject: Re: i386 intel syntax integer load/store fp instructions
- References: <s173d1d6.061@emea1-mh.id2.novell.com>
On Mon, Oct 18, 2004 at 03:23:42PM +0200, Jan Beulich wrote:
> An update to the previously submitted x86 Intel syntax assembly
> adjustments patch, now retaining fildq/fistpq/fisttpq in AT&T mode.
I guess this is OK. Before you commit, please fix some coding standard
violations.
+ /* Note that the value returned is meaningful only for opcodes with (memory)
+ operands, hence the code here is free to improperly handle opcodes that
+ have no operands (for better performance and smaller code). */
Formatting.
+ /* case 'c':
+ if (mnemonic[2] == 'l')
+ return 3; * fclex *
+ break; */
+ /* case 'd':
+ if (mnemonic[2] != 'i' || mnemonic[3] != 'v')
+ return 3; * fdisi/fdecstp *
+ break; */
+ /* case 'e':
+ return mnemonic[2] == 'm' ? 0 * femms * : 3 * feni * ; */
+ case 'i':
+ return /* mnemonic[2] == 'n' ? 3 * finit/fincstp * : */ 2 /* integer op */;
No commented out code please.
+ && (~i.tm.opcode_modifier & (No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_xSuf|No_qSuf)))
Overly long line, spaces around |. I know all the tc-i386.c code
doesn't adhere to the standard, but let's not make it worse.
+ unsigned int suffixes = ~i.tm.opcode_modifier & (No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_xSuf|No_qSuf);
Ditto.
+ && !(i.tm.opcode_modifier & (DefaultSize|IgnoreSize))))
Spaces around |
+ && !(i.tm.opcode_modifier & (IgnoreSize|FloatMF))
Again.
+ as_bad (_("invalid operand for '%s' ('%s' unexpected)"),
+ current_templates->start->name, cur_token.str);
Formatting.
--
Alan Modra
IBM OzLabs - Linux Technology Centre