This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] MIPS: Use BFD_RELOC_UNUSED when no relocation


On Mon, 19 Jul 2004, Eric Christopher wrote:

> It looks ok, but no mention of testing. And I'd appreciate it if you

 The original submission was successfully tested and announced as such.  
I have not tested this small update separately, but only as a part of my
whole current patch set, so I didn't mention it, sorry.

> could test it on something like mips64vr-elf so you can test mips16
> support.

 Anyway, since there's never too much testing and since you've requested
the mips64vr-elf target explicitly, I reran the test suite again, with the
tree configured for this exact target.  There were no new regressions, but
guess what -- I discovered a failure in an unrelated test case which
triggers for this target, due to different gas configuration defaults.  
Here is a fix.

2004-07-20  Maciej W. Rozycki  <macro@linux-mips.org>

	* gas/mips/elf-rel19.d: Pass -march=mips1 to gas as the test 
	expects load delay slots.

 OK to apply?

  Maciej

binutils-2.15.91-20040714-mips-elf-rel19.patch
diff -up --recursive --new-file binutils-2.15.91-20040715.macro/gas/testsuite/gas/mips/elf-rel19.d binutils-2.15.91-20040715/gas/testsuite/gas/mips/elf-rel19.d
--- binutils-2.15.91-20040715.macro/gas/testsuite/gas/mips/elf-rel19.d	2004-07-09 03:25:25.000000000 +0000
+++ binutils-2.15.91-20040715/gas/testsuite/gas/mips/elf-rel19.d	2004-07-20 14:47:54.000000000 +0000
@@ -1,5 +1,5 @@
 #objdump: -dr
-#as: -mabi=32 -KPIC
+#as: -mabi=32 -march=mips1 -KPIC
 
 .*:     file format .*
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]