This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Patch to improve MIPS %hi/%lo matching
> > #if 0 /* GCC code motion plus incomplete dead code elimination
> > can leave a %hi without a %lo. */
> > if (pass == 1)
> > as_warn_where (l->fixp->fx_file, l->fixp->fx_line,
> > _("Unmatched %%hi reloc"));
> > #endif
> >
> > but I've no idea which version it applies to. I certainly _hope_
> > modern gccs aren't affected...
>
> Can you add some indication of the gcc version to the comment?
> "gcc versions earlier than ??? may emit...". This gives us a chance to
> catch potential bugs after those gcc versions become obsolete.
The code was added into the Cygnus repository on 6-Jan-99 so I'll hazard
a guess it was for versions of gcc available at that time. If/when the
behavior has stopped I don't know. I think there's a testcase, but
unfortunately I've lost track of the old Cygnus PRMS database. I'll take
a look and see if I can find it. It'd still take some archiving to find
out when/if we stopped doing this :)
-eric
--
Eric Christopher <echristo@redhat.com>