This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: PATCH: BZ/175: Fix dynamic string offset
- From: Jim Wilson <wilson at specifixinc dot com>
- To: "H. J. Lu" <hjl at lucon dot org>
- Cc: jakub at redhat dot com, binutils at sources dot redhat dot com
- Date: 31 May 2004 14:24:03 -0700
- Subject: Re: PATCH: BZ/175: Fix dynamic string offset
- References: <20040529222358.GA9983@lucon.org>
On Sat, 2004-05-29 at 15:23, H. J. Lu wrote:
> I think Alan may be right. I backed out my patch for the time being. I
> think we should pass r_addend to _bfd_merged_section_offset only for
> section symbols. For local and global symbols, merge will adjust their
> st_values. We shouldn't pass r_addend against them to
> _bfd_merged_section_offset.
This looks reasonable to me, not that I know what I'm talking about
though. This seems to implement the idea of keeping internal and
programmer offsets separate, as you aren't passing the programmer offset
through to bfd_merged_section_offset now.
If this is right, then does that imply that elf32-ppc.c and
elf64-alpha.c are broken?
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com