This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: BZ/175: Fix dynamic string offset


On Tue, May 25, 2004 at 06:09:38PM -0700, H. J. Lu wrote:
> On Sat, May 22, 2004 at 11:27:22AM +0930, Alan Modra wrote:
> > 
> > I doubt this patch is complete.  If you need to special case certain
> > accesses in relax_section, how is it that relocate_section escapes a
> > need for the same special case code?  This might prove more difficult,
> > as you might need to pull apart _bfd_elf_rela_local_sym.  I'm also still
> > concerned that other ia64 code sequences might use R_IA64_LTOFF22X in a
> > way that requires you include the addend.  Please discuss this with Jim,
> > I'm not familiar enough with ia64 to know.
> > 
> 
> elfNN_ia64_relax_section shouldn't calls _bfd_merged_section_offset just
> because tsec->sec_info_type == ELF_INFO_TYPE_MERGE. For local symbols,
> it should also check
> 
> (tsec->flags & SEC_MERGE) && ELF_ST_TYPE (isym->st_info) == STT_SECTION
> 
> 

Here is the updated one.


H.J.

Attachment: bfd-ia64-merge-4.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]