Re: Correct the type of _PROCEDURE_LINKAGE_TABLE_

[Alan Modra <amodra at bigpond dot net dot au>]

On Thu, May 27, 2004 at 11:51:45AM -0400, Daniel Jacobowitz wrote:
> On Thu, May 27, 2004 at 09:36:49AM +0930, Alan Modra wrote:
> > On Wed, May 26, 2004 at 05:31:24PM -0400, Daniel Jacobowitz wrote:
> > > objdump will not dump the PLT as instructions if it starts
> > > with an STT_OBJECT symbol.
> > 
> > Really?  Fix objdump then.  _PROCEDURE_LINKAGE_TABLE_ isn't a function,
> > nor are many other symbols in code sections.
> 
> >From the gABI:
> 
> STT_OBJECT
>                   The symbol is associated with a data object, such as a variable,
>                   an array, and so on.
> 
> STT_FUNC
>                   The symbol is associated with a function or other executable
>                   code.
> 
> _PROCEDURE_LINKAGE_TABLE_ in this case is "other executable code", and not a "data
> object", so I think it should be STT_FUNC.

Isn't a table an array of sorts?  Perhaps it won't hurt anything to
change the type, but who knows?  If you can twist Ian's arm to approve
it, then fine!  Otherwise, I'm inclined to be grumpy and reject the
patch.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre