This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: gas:Reject ++ and --


Alan Modra wrote:
On Sat, May 22, 2004 at 11:49:59AM -0400, Jakub Jelinek wrote:

Still, I'm not sure I like the new gas behaviour.


Yes, it's wrong.  I should have thought of the wretched preprocessor
before allowing the patch.  x86 has some hacks to prevent whitespace
being eaten, and "- - c" isn't turned into "--c", so the case you
found for sparc would work on x86.  However,"+ + c" is turned into
"++c".  See tc-i386.c:extra_symbol_chars.

Really, the preprocessor should never completely consume whitespace,
but curing that will no doubt expose many places in target files that
expect all whitespace to be eaten.  Until someone spends the time to
rewrite the preprocessor, I think Nathan's patch should be reverted.
I agree. I'll have to find another way ...

nathan

--
Nathan Sidwell    ::   http://www.codesourcery.com   ::     CodeSourcery LLC
nathan@codesourcery.com    ::     http://www.planetfall.pwp.blueyonder.co.uk



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]