This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [rfa] Re: gcc 3.3.3 and interworking
- From: Daniel Jacobowitz <drow at false dot org>
- To: binutils at sources dot redhat dot com, nickc at redhat dot com, rearnsha at arm dot com
- Date: Mon, 3 May 2004 13:20:56 -0400
- Subject: Re: [rfa] Re: gcc 3.3.3 and interworking
- References: <INEKJJILJLMPDJPJFMPGIEAKEMAA.wintermute2k4@ntlworld.com> <INEKJJILJLMPDJPJFMPGAEANEMAA.wintermute2k4@ntlworld.com> <20040423023058.GA32415@nevyn.them.org> <20040423182215.GA15743@nevyn.them.org>
On Fri, Apr 23, 2004 at 02:22:15PM -0400, Daniel Jacobowitz wrote:
> On Thu, Apr 22, 2004 at 10:30:58PM -0400, Daniel Jacobowitz wrote:
> > Ah-ha - I should have guessed. I eliminated most explicit treatment of
> > R_ARM_PLT32 relocations recently, to fix this sort of bug among others;
> > I've had the one missing reference on my TODO list for a couple of
> > months, and you just hit it. Could you test this patch to HEAD?
>
> This worked for him - is it OK to check in?
Ping? I'd like to include this patch in 2.15.
>
> > 2004-04-22 Daniel Jacobowitz <drow@mvista.com>
> >
> > * elf32-arm.h (elf32_arm_relocate_section): Remove R_ARM_PLT32
> > special case.
> >
> > --- elf32-arm.h.orig 2004-04-22 22:11:15.000000000 -0400
> > +++ elf32-arm.h 2004-04-22 22:28:37.000000000 -0400
> > @@ -2229,6 +2229,8 @@ elf32_arm_relocate_section (output_bfd,
> > case R_ARM_PC24:
> > case R_ARM_ABS32:
> > case R_ARM_THM_PC22:
> > + case R_ARM_PLT32:
> > +
> > if (info->shared
> > && (
> > (!info->symbolic && h->dynindx != -1)
> > @@ -2262,11 +2264,6 @@ elf32_arm_relocate_section (output_bfd,
> > relocation = 0;
> > break;
> >
> > - case R_ARM_PLT32:
> > - if (h->plt.offset != (bfd_vma)-1)
> > - relocation = 0;
> > - break;
> > -
> > default:
> > if (unresolved_reloc)
> > _bfd_error_handler
> >
>
> --
> Daniel Jacobowitz
> MontaVista Software Debian GNU/Linux Developer
>
--
Daniel Jacobowitz