Re: nop in load-delay-slot (on MIPS o32 PIC code)

[Thiemo Seufer <ica2_ts at csv dot ica dot uni-stuttgart dot de>]

Atsushi Nemoto wrote:
> >>>>> On Wed, 21 Apr 2004 17:35:20 +0200, Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de> said:
> >> I created a patch against 040420 snapshot (see attached).  Not so
> >> big.  Could you review it?
> 
> ica2_ts> It seems like you missed a few ones, at lines 4006 and
> ica2_ts> 6216. Any yes, wrapping it in a, say, load_delay_nop()
> ica2_ts> function would also be better.
> 
> Thank you.  I looked codes more closely.  The lines 4006 and 6216 (and
> also 5345, 5677) are already covered by reg_needs_delay() and should
> not be changed. (these lines are immediate after relax_switch() so we
> can not assume this is really a load delay slot, is this right?)
> 
> Here is a revised patch.

Ok (with an appropriate ChangeLog and adjusted testcases).


Thiemo