This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: IRIX local section names broke mips-elf testsuite results
- From: Richard Sandiford <rsandifo at redhat dot com>
- To: binutils at sources dot redhat dot com
- Date: Tue, 13 Apr 2004 13:09:31 +0100
- Subject: Re: IRIX local section names broke mips-elf testsuite results
- References: <20040412192332.GA10417@nevyn.them.org>
Daniel Jacobowitz <drow@false.org> writes:
> There are files in both the gas and binutils testsuites which expect local
> sections to be unnamed. Richard, would you mind fixing these? Probably
> they can just accept the section names.
Gah, sorry for being so lame. The patch below should fix it.
Tested on mips-elf, mips64-elf, mipsel-elf, mips64el-elf,
mips64-linux-gnu and mips64el-linux-gnu. OK to install?
Note that I've made the names optional because some of these tests are
used by both IRIX and non-IRIX emulations. Even when a test is only
used by IRIX emulations, the names aren't needed by all targets (e.g.,
they aren't really needed by *-elf). Making the names optional seems
better there too.
> I imagine they fail on IRIX also?
Yes, but most testcases do, mainly because of the lack of .pdr. I've been
meaning to clean up the testsuite so that it's useful for mips-sgi-irix* too,
but it's always been lower priority than something else.
Richard
gas/testsuite/
* gas/elf/section2.e-mips: Allow named section symbols.
* gas/mips/{,el}empic.d, gas/mips/mips{,el}16-[ef].d: Likewise.
binutils/testsuite
* binutils-all/readelf.ss-mips: Allow named section symbols.
Index: gas/testsuite/gas/elf/section2.e-mips
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/elf/section2.e-mips,v
retrieving revision 1.2
diff -c -p -F^\([(a-zA-Z0-9_]\|#define\) -r1.2 section2.e-mips
*** gas/testsuite/gas/elf/section2.e-mips 10 Jun 2001 18:16:51 -0000 1.2
--- gas/testsuite/gas/elf/section2.e-mips 13 Apr 2004 11:34:44 -0000
***************
*** 2,10 ****
Symbol table '.symtab' contains 7 entries:
Num: Value[ ]* Size Type Bind Vis Ndx Name
0: 0+0 0 NOTYPE LOCAL DEFAULT UND
! 1: 0+0 0 SECTION LOCAL DEFAULT 1
! 2: 0+0 0 SECTION LOCAL DEFAULT 2
! 3: 0+0 0 SECTION LOCAL DEFAULT 3
! 4: 0+0 0 SECTION LOCAL DEFAULT 6
! 5: 0+0 0 SECTION LOCAL DEFAULT 4
! 6: 0+0 0 SECTION LOCAL DEFAULT 5
--- 2,10 ----
Symbol table '.symtab' contains 7 entries:
Num: Value[ ]* Size Type Bind Vis Ndx Name
0: 0+0 0 NOTYPE LOCAL DEFAULT UND
! 1: 0+0 0 SECTION LOCAL DEFAULT 1 (|\.text)
! 2: 0+0 0 SECTION LOCAL DEFAULT 2 (|\.data)
! 3: 0+0 0 SECTION LOCAL DEFAULT 3 (|\.bss)
! 4: 0+0 0 SECTION LOCAL DEFAULT 6 (|A)
! 5: 0+0 0 SECTION LOCAL DEFAULT 4 (|\.reginfo)
! 6: 0+0 0 SECTION LOCAL DEFAULT 5 (|\.pdr)
Index: gas/testsuite/gas/mips/elempic.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/mips/elempic.d,v
retrieving revision 1.7
diff -c -p -F^\([(a-zA-Z0-9_]\|#define\) -r1.7 elempic.d
*** gas/testsuite/gas/mips/elempic.d 3 Sep 2003 08:26:51 -0000 1.7
--- gas/testsuite/gas/mips/elempic.d 13 Apr 2004 11:07:29 -0000
***************
*** 9,20 ****
.*: +file format elf.*mips.*
SYMBOL TABLE:
! 0+0000000 l d \.text 0+0000000
! 0+0000000 l d \.data 0+0000000
! 0+0000000 l d \.bss 0+0000000
! 0+0000000 l d \.foo 0+0000000
! 0+0000000 l d \.reginfo 0+0000000
! 0+0000000 l d \.(mdebug|pdr) 0+0000000
0+0000004 l \.text 0+0000000 l2
0+0000000 \*UND\* 0+0000000 g1
0+0000000 \*UND\* 0+0000000 g2
--- 9,20 ----
.*: +file format elf.*mips.*
SYMBOL TABLE:
! 0+0000000 l d \.text 0+0000000 (|\.text)
! 0+0000000 l d \.data 0+0000000 (|\.data)
! 0+0000000 l d \.bss 0+0000000 (|\.bss)
! 0+0000000 l d \.foo 0+0000000 (|\.foo)
! 0+0000000 l d \.reginfo 0+0000000 (|\.reginfo)
! 0+0000000 l d \.(mdebug|pdr) 0+0000000 (|\.mdebug|\.pdr)
0+0000004 l \.text 0+0000000 l2
0+0000000 \*UND\* 0+0000000 g1
0+0000000 \*UND\* 0+0000000 g2
Index: gas/testsuite/gas/mips/empic.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/mips/empic.d,v
retrieving revision 1.10
diff -c -p -F^\([(a-zA-Z0-9_]\|#define\) -r1.10 empic.d
*** gas/testsuite/gas/mips/empic.d 3 Sep 2003 08:26:51 -0000 1.10
--- gas/testsuite/gas/mips/empic.d 13 Apr 2004 11:07:29 -0000
***************
*** 8,19 ****
.*: +file format elf.*mips.*
SYMBOL TABLE:
! 0+0000000 l d \.text 0+0000000
! 0+0000000 l d \.data 0+0000000
! 0+0000000 l d \.bss 0+0000000
! 0+0000000 l d \.foo 0+0000000
! 0+0000000 l d \.reginfo 0+0000000
! 0+0000000 l d \.(mdebug|pdr) 0+0000000
0+0000004 l \.text 0+0000000 l2
0+0000000 \*UND\* 0+0000000 g1
0+0000000 \*UND\* 0+0000000 g2
--- 8,19 ----
.*: +file format elf.*mips.*
SYMBOL TABLE:
! 0+0000000 l d \.text 0+0000000 (|\.text)
! 0+0000000 l d \.data 0+0000000 (|\.data)
! 0+0000000 l d \.bss 0+0000000 (|\.bss)
! 0+0000000 l d \.foo 0+0000000 (|\.foo)
! 0+0000000 l d \.reginfo 0+0000000 (|\.reginfo)
! 0+0000000 l d \.(mdebug|pdr) 0+0000000 (|\.mdebug|\.pdr)
0+0000004 l \.text 0+0000000 l2
0+0000000 \*UND\* 0+0000000 g1
0+0000000 \*UND\* 0+0000000 g2
Index: gas/testsuite/gas/mips/mips16-e.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/mips/mips16-e.d,v
retrieving revision 1.6
diff -c -p -F^\([(a-zA-Z0-9_]\|#define\) -r1.6 mips16-e.d
*** gas/testsuite/gas/mips/mips16-e.d 3 Sep 2003 08:26:51 -0000 1.6
--- gas/testsuite/gas/mips/mips16-e.d 13 Apr 2004 11:07:29 -0000
***************
*** 7,18 ****
.*: +file format elf.*mips.*
SYMBOL TABLE:
! 0+0000000 l d \.text 0+0000000
! 0+0000000 l d \.data 0+0000000
! 0+0000000 l d \.bss 0+0000000
! 0+0000000 l d foo 0+0000000
! 0+0000000 l d \.reginfo 0+0000000
! 0+0000000 l d \.(mdebug|pdr) 0+0000000
0+0000002 l \.text 0+0000000 0xf0 l1
0+0000004 l \.text 0+0000000 0xf0 L1.1
0+0000000 \*UND\* 0+0000000 g1
--- 7,18 ----
.*: +file format elf.*mips.*
SYMBOL TABLE:
! 0+0000000 l d \.text 0+0000000 (|\.text)
! 0+0000000 l d \.data 0+0000000 (|\.data)
! 0+0000000 l d \.bss 0+0000000 (|\.bss)
! 0+0000000 l d foo 0+0000000 (|foo)
! 0+0000000 l d \.reginfo 0+0000000 (|\.reginfo)
! 0+0000000 l d \.(mdebug|pdr) 0+0000000(| \.mdebug| \.pdr)
0+0000002 l \.text 0+0000000 0xf0 l1
0+0000004 l \.text 0+0000000 0xf0 L1.1
0+0000000 \*UND\* 0+0000000 g1
Index: gas/testsuite/gas/mips/mips16-f.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/mips/mips16-f.d,v
retrieving revision 1.7
diff -c -p -F^\([(a-zA-Z0-9_]\|#define\) -r1.7 mips16-f.d
*** gas/testsuite/gas/mips/mips16-f.d 3 Sep 2003 08:26:51 -0000 1.7
--- gas/testsuite/gas/mips/mips16-f.d 13 Apr 2004 11:07:29 -0000
***************
*** 7,18 ****
.*: +file format elf.*mips.*
SYMBOL TABLE:
! 0+0000000 l d \.text 0+0000000
! 0+0000000 l d \.data 0+0000000
! 0+0000000 l d \.bss 0+0000000
! 0+0000000 l d foo 0+0000000
! 0+0000000 l d \.reginfo 0+0000000
! 0+0000000 l d \.(mdebug|pdr) 0+0000000
0+0000002 l \.text 0+0000000 0xf0 l1
--- 7,18 ----
.*: +file format elf.*mips.*
SYMBOL TABLE:
! 0+0000000 l d \.text 0+0000000 (|\.text)
! 0+0000000 l d \.data 0+0000000 (|\.data)
! 0+0000000 l d \.bss 0+0000000 (|\.bss)
! 0+0000000 l d foo 0+0000000 (|foo)
! 0+0000000 l d \.reginfo 0+0000000 (|\.reginfo)
! 0+0000000 l d \.(mdebug|pdr) 0+0000000 (|\.mdebug|\.pdr)
0+0000002 l \.text 0+0000000 0xf0 l1
Index: gas/testsuite/gas/mips/mipsel16-e.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/mips/mipsel16-e.d,v
retrieving revision 1.3
diff -c -p -F^\([(a-zA-Z0-9_]\|#define\) -r1.3 mipsel16-e.d
*** gas/testsuite/gas/mips/mipsel16-e.d 3 Sep 2003 08:26:51 -0000 1.3
--- gas/testsuite/gas/mips/mipsel16-e.d 13 Apr 2004 11:07:29 -0000
***************
*** 8,19 ****
.*: +file format elf.*mips.*
SYMBOL TABLE:
! 0+0000000 l d \.text 0+0000000
! 0+0000000 l d \.data 0+0000000
! 0+0000000 l d \.bss 0+0000000
! 0+0000000 l d foo 0+0000000
! 0+0000000 l d \.reginfo 0+0000000
! 0+0000000 l d \.(mdebug|pdr) 0+0000000
0+0000002 l \.text 0+0000000 0xf0 l1
0+0000004 l \.text 0+0000000 0xf0 L1.1
0+0000000 \*UND\* 0+0000000 g1
--- 8,19 ----
.*: +file format elf.*mips.*
SYMBOL TABLE:
! 0+0000000 l d \.text 0+0000000 (|\.text)
! 0+0000000 l d \.data 0+0000000 (|\.data)
! 0+0000000 l d \.bss 0+0000000 (|\.bss)
! 0+0000000 l d foo 0+0000000 (|foo)
! 0+0000000 l d \.reginfo 0+0000000 (|\.reginfo)
! 0+0000000 l d \.(mdebug|pdr) 0+0000000 (|\.mdebug|\.pdr)
0+0000002 l \.text 0+0000000 0xf0 l1
0+0000004 l \.text 0+0000000 0xf0 L1.1
0+0000000 \*UND\* 0+0000000 g1
Index: gas/testsuite/gas/mips/mipsel16-f.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/mips/mipsel16-f.d,v
retrieving revision 1.6
diff -c -p -F^\([(a-zA-Z0-9_]\|#define\) -r1.6 mipsel16-f.d
*** gas/testsuite/gas/mips/mipsel16-f.d 3 Sep 2003 08:26:51 -0000 1.6
--- gas/testsuite/gas/mips/mipsel16-f.d 13 Apr 2004 11:07:29 -0000
***************
*** 8,19 ****
.*: +file format elf.*mips.*
SYMBOL TABLE:
! 0+0000000 l d \.text 0+0000000
! 0+0000000 l d \.data 0+0000000
! 0+0000000 l d \.bss 0+0000000
! 0+0000000 l d foo 0+0000000
! 0+0000000 l d \.reginfo 0+0000000
! 0+0000000 l d \.(mdebug|pdr) 0+0000000
0+0000002 l \.text 0+0000000 0xf0 l1
--- 8,19 ----
.*: +file format elf.*mips.*
SYMBOL TABLE:
! 0+0000000 l d \.text 0+0000000 (|\.text)
! 0+0000000 l d \.data 0+0000000 (|\.data)
! 0+0000000 l d \.bss 0+0000000 (|\.bss)
! 0+0000000 l d foo 0+0000000 (|foo)
! 0+0000000 l d \.reginfo 0+0000000 (|\.reginfo)
! 0+0000000 l d \.(mdebug|pdr) 0+0000000 (|\.mdebug|.pdr)
0+0000002 l \.text 0+0000000 0xf0 l1
Index: binutils/testsuite/binutils-all/readelf.ss-mips
===================================================================
RCS file: /cvs/src/src/binutils/testsuite/binutils-all/readelf.ss-mips,v
retrieving revision 1.3
diff -c -p -F^\([(a-zA-Z0-9_]\|#define\) -r1.3 readelf.ss-mips
*** binutils/testsuite/binutils-all/readelf.ss-mips 13 Feb 2002 09:48:40 -0000 1.3
--- binutils/testsuite/binutils-all/readelf.ss-mips 13 Apr 2004 11:07:29 -0000
***************
*** 2,12 ****
Symbol table '.symtab' contains 12 entries:
Num: Value Size Type Bind Vis Ndx Name
0: 00000000 0 NOTYPE LOCAL DEFAULT UND
! 1: 00000000 0 SECTION LOCAL DEFAULT .
! 2: 00000000 0 SECTION LOCAL DEFAULT .
! 3: 00000000 0 SECTION LOCAL DEFAULT .
! 4: 00000000 0 SECTION LOCAL DEFAULT .
! 5: 00000000 0 SECTION LOCAL DEFAULT .
6: 00000000 0 OBJECT GLOBAL DEFAULT . text_symbol
7: 00000000 0 NOTYPE LOCAL DEFAULT . static_text_symbol
8: 00000000 0 NOTYPE GLOBAL DEFAULT UND external_symbol
--- 2,12 ----
Symbol table '.symtab' contains 12 entries:
Num: Value Size Type Bind Vis Ndx Name
0: 00000000 0 NOTYPE LOCAL DEFAULT UND
! 1: 00000000 0 SECTION LOCAL DEFAULT . (|\.text)
! 2: 00000000 0 SECTION LOCAL DEFAULT . (|\.data)
! 3: 00000000 0 SECTION LOCAL DEFAULT . (|\.bss)
! 4: 00000000 0 SECTION LOCAL DEFAULT . (|\.reginfo)
! 5: 00000000 0 SECTION LOCAL DEFAULT . (|\.pdr)
6: 00000000 0 OBJECT GLOBAL DEFAULT . text_symbol
7: 00000000 0 NOTYPE LOCAL DEFAULT . static_text_symbol
8: 00000000 0 NOTYPE GLOBAL DEFAULT UND external_symbol