This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: ARM mapping symbols
- From: Nick Clifton <nickc at redhat dot com>
- To: Bruno De Bus <bdebus at elis dot ugent dot be>
- Cc: binutils at sources dot redhat dot com
- Date: Mon, 08 Mar 2004 10:16:22 +0000
- Subject: Re: ARM mapping symbols
- References: <Pine.LNX.4.44.0402241735360.31265-200000@trappist.elis.UGent.be>
Hi Bruno,
[Please could send patches to the GNU binary utilities, including
GAS, to the binutils mailing list: binutils@sources.redhat.com]
> I noticed that you implemented mapping symbols for the
> ARM-architecture. However, it seems like the literal pools (the
> main reason for data in code on the ARM ) do not get a $d
> symbol. The attached patch solves the problem.
Thank you very much for submitting this patch. There is one initial
problem however: do you have a copyright assignment on file with the
FSF ? Without such an assignment we could not accept the patch :-(
> It's just a quick hack, I simply force the addition of a $d
> symbol before each literal pool. For a clean fix, I would have
> needed to change some of the core gas files.
Which files ? [Clean fixes are always preferred to quick hacks :-)]
I have some reservations about the patch:
* Why is the forced argument needed for the mapping_state() function
? Surely if the last mapping symbol emitted was a data symbol,
then there is no need to emit a new one ?
* If you are going to emit a data symbol at the start of the literal
pool, then you will also need to emit a text symbol at the end of
the pool, so that debuggers etc can tell that .text section now
contains code and not data.
Cheers
Nick