This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: PATCH: Fix mixed ELF32 and ELF64 in archive
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: "H. J. Lu" <hjl at lucon dot org>
- Cc: binutils at sources dot redhat dot com
- Date: Sun, 29 Feb 2004 12:44:17 +1030
- Subject: Re: PATCH: Fix mixed ELF32 and ELF64 in archive
- References: <20040227224628.GA17500@lucon.org>
On Fri, Feb 27, 2004 at 02:46:28PM -0800, H. J. Lu wrote:
> When there are mixed ELF32 and ELF64 objects in archive and linker
> supporting both, linker gets really confused since the wrong
> value/function are used. When we deal with archive, we can't assume
> the size and we have to get the right thing from the backend. This
> patch fixes it. Ok to install?
This is OK. Can I ask you to do a little more, and move
elf_link_add_archive_symbols and elf_link_is_defined_archive_symbol
to elflink.c? That's where they belong if there are no size dependent
structures, macros etc. left. Moving them to elflink.c will prove
that your patch is complete too.
> 2004-02-27 H.J. Lu <hongjiu.lu@intel.com>
>
> * elflink.h (elf_link_is_defined_archive_symbol): Get the size
> of ELF symbol table entry from backend.
> (elf_link_add_archive_symbols): Call bfd_link_add_symbols
> instead of elf_link_add_object_symbols.
--
Alan Modra
IBM OzLabs - Linux Technology Centre