This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH] Re: [Mingw-users] binutils 20040120-1 & VC6 .lib incompatibility?


	Looks like the diff didn't get applied correctly.  There was a continue that should have turned into a break.  Only the change to the first line got applied.  Once I changed the continue into a break, the thing started working again :-).

-Eric

===================================================================
RCS file: /cvs/src/src/ld/emultempl/pe.em,v
retrieving revision 1.87
diff -c -3 -p -r1.87 pe.em
*** emultempl/pe.em	3 Jan 2004 12:39:07 -0000	1.87
--- emultempl/pe.em	3 Feb 2004 10:37:46 -0000
*************** gld_${EMULATION_NAME}_after_open (void)
*** 1139,1146 ****
  		       extension, and use that for the remainder of the
  		       comparisons.  */
  		    pnt = strrchr (is3->the_bfd->filename, '.');
! 		    if (pnt != NULL && strcmp (pnt, ".dll") != 0)
! 		      continue;
  		  }
  
  		if (is3 == NULL)
--- 1139,1146 ----
  		       extension, and use that for the remainder of the
  		       comparisons.  */
  		    pnt = strrchr (is3->the_bfd->filename, '.');
! 		    if (pnt != NULL && strcmp (pnt, ".dll") == 0)
! 		      break;
  		  }
  
  		if (is3 == NULL)


-----Original Message-----
From: Nick Clifton [mailto:nickc@redhat.com]
Sent: Wednesday, February 04, 2004 4:13 AM
To: Danny Smith
Cc: binutils; cls@seawood.org; Eric Youngdale
Subject: Re: [PATCH] Re: [Mingw-users] binutils 20040120-1 & VC6 .lib
incompatibility?


Hi Danny,

> The regression reported here:
>
> http://mail.gnu.org/archive/html/bug-binutils/2004-01/msg00053.html

> The following fixes in my tests:
>
> ld/ChangeLog
>
> 2004-02-04  Danny Smith  <dannysmith@users.sourceforge.net>
>
> 	* emultempl/pe.em (_after_open): Fix thinko in 2003-12-18 patch.

Approved and applied.

Cheers
        Nick
        


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]