This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Unreviewed Patch : Patch H8/300 : Linker relaxation for ldc and stc instructions
- From: "Anil Paranjape" <AnilP1 at KPITCummins dot com>
- To: "Kazu Hirata" <kazu at cs dot umass dot edu>,<binutils at sources dot redhat dot com>
- Date: Wed, 4 Feb 2004 09:40:58 +0530
- Subject: Unreviewed Patch : Patch H8/300 : Linker relaxation for ldc and stc instructions
Hi ,
Please review the patch and ld test case from following link,
http://sources.redhat.com/ml/binutils/2004-01/msg00423.html
Regards,
Anil
-----Original Message-----
From: Anil Paranjape
Sent: Tuesday, January 27, 2004 6:15 PM
To: 'Kazu Hirata'; binutils@sources.redhat.com
Subject: RE: Patch H8/300 : Linker relaxation for ldc and stc
instructions
Hi Kazu,
Please find attached complete patch including previous patches and patch which adds new test case in ld testsuite. No new regressions found after applying this patch.
ChangeLog for testcase,
2004-01-23 Anil Paranjpe <anilp1@KPITCummins.com>
* ld-h8300/h8300-exp: Run the relax-5 test.
* ld-h8300/relax-5.s: New file: Source for relax-5 test.
* ld-h8300/relax-5.d: New file: Expected output and commands for
assembling and linking the relax-5 test.
* ld-h8300/relax-5-coff.d: New file: Variant for the COFF based
toolchain.
ChangeLog for bfd/(coff and elf32)-h8300.c
2004-01-23 Anil Paranjpe <anilp1@KPITCummins.com>
* coff-h8300.c: Added comments about relaxation for ldc.w and stc.w.
* elf32-h8300.c: Likewise.
Regards,
Anil
-----Original Message-----
From: Kazu Hirata [mailto:kazu@cs.umass.edu]
Sent: Saturday, January 24, 2004 2:17 PM
To: Anil Paranjape
Cc: binutils@sources.redhat.com
Subject: Re: Patch H8/300 : Linker relaxation for ldc and stc
instructions
Hi Anil,
> Please find a patch which adds into comments for relaxation of ldc.w
> and stc.w instructions.
Thanks for an update. Would you provide a ChangeLog entry for
coff-h8300.c and elf32-h8300.c? Speaking of ChangeLog, do you have a
ChangeLog entry for your testcases?
> + "bxor", "ldc.w", "stc.w" and "mov.[bwl]"
~~~~~
Please leave a comma before and. Although some people omit it or say
it's optional, many grammar resources (and my English teacher :-) say
it's required.
> + "stc.w" and "mov.[bwl]"
Likewise.
You might want to submit a complete patch, including all ChangeLog
entries and patches, so that it will be easier for Alan or Nick to
review and apply your patch.
Thanks,
Kazu Hirata