This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Fix demangler in symbol versioning


On Thu, Dec 04, 2003 at 05:40:21PM -0500, Ian Lance Taylor wrote:
> "H. J. Lu" <hjl@lucon.org> writes:
> 
> > On Thu, Dec 04, 2003 at 03:58:40PM -0500, DJ Delorie wrote:
> > > 
> > > > +      cxx_sym = cplus_demangle (sym, (DMGL_PARAMS
> > > > +				      | DMGL_ANSI
> > > > +				      | DMGL_VERBOSE));
> > > 
> > > Are you sure you want verbose?
> > 
> > It looks like it isn't need. Should I add DMGL_TYPES? It is used
> > in test-demangle.c.
> 
> DMGL_TYPES tells the demangler to see if the string is the mangled
> version of a type encoding.  I don't think the compiler will ever use
> a type encoding as an external symbol name--that doesn't even really
> make sense--so I don't think there is any need for DMGL_TYPES here.
> 

Will it lead to incorrect output? If not, I'd like to add it.


H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]