This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] Fix for ldm/stm instructions in H8S
- From: Nick Clifton <nickc at redhat dot com>
- To: AsgariJ at KPITCummins dot com
- Cc: kazu at cs dot umass dot edu, binutils at sources dot redhat dot com
- Date: Tue, 25 Nov 2003 16:12:56 +0000
- Subject: Re: [PATCH] Fix for ldm/stm instructions in H8S
- References: <69595093233BB547BB70CF5E492B63F201D03FAA@sohm.kpit.com>
Hi Asgari,
> I have modified patch for H8S and H8SX targets. Also I have created
> patches for multiples.s and h8300.exp in gas/h8300 testsuite. This
> was tested with binutils-031111 testsuite and found okay.
Thanks very much - this patch is much better. There was one small
omission - the h8300 testcase t01_mov.s had a couple of illegal
register pairings in it, which lead to an extra 78 unexpected failures
when the gas testsuite was run for the h8300-elf toolchain.
I have applied your patch together with a fix to t01_mov.s and
t01_mov.exp so that there are no new testsuite failures.
Cheers
Nick
gas/ChangeLog
2003-11-25 Asgari Jinia <asgarij@kpitcummins.com>
* config/tc-h8300.c (md_assemble): Check operands validity for
ldm/stm.
(get_operand): Check register pair's validity as per technical
note TN-H8*-193A/E from Renesas for H8s and for H8Sx manual.
gas/testsuite/ChangeLog
2003-11-25 Asgari Jinia <asgarij@kpitcummins.com>
* gas/h8300/multiples.s : Add instructions for H8s.
* gas/h8300/h8300.exp (do_h8300s_multiple) : Add more test
conditions for instructions for H8s.
* gas/h8300/t01_mov.s: Correct illegal ldm/stm register pairings.
* gas/h8300/t01_mov.exp: Update expected results.