This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

PATCH: Support '*' in pattern and fix a typo


On Thu, Oct 23, 2003 at 07:50:43PM -0700, H. J. Lu wrote:
> On Thu, Oct 23, 2003 at 11:29:20AM -0700, H. J. Lu wrote:
> > On Tue, Oct 21, 2003 at 10:57:36PM -0700, H. J. Lu wrote:
> > 
> > > > I think we need something different from wildcardp, which can handle
> > > > "foo\*bar", for setting the new wildcard bit. We can modify it after
> > > > your patch is checked in.
> > > > 
> > > 
> > > I am thinking about instead of adding
> > > 
> > > unsigned int wildcard : 1;
> > > 
> > > we add
> > > 
> > > const char *symbol;
> > > 
> > > If
> > > 
> > > const char *pattern;
> > > 
> > > is a wildcard, symbol will be NULL. Otherwise, symbol will point to
> > > pattern if pattern has no backslash or point to a copy of pattern
> > > with backslashes removed. size_dynamic_sections will lookup symbol
> > > like
> > > 
> > > 	if (!d->symver && d->symbol != NULL)
> > > 	  {
> > > 	    ...
> > > 	    elf_link_hash_lookup
> > > 	    ...
> > > 	 }
> > > 
> > 
> > Here is the patch to implement it.
> > 
> 
> The patch is incorrect. Here is an update.
> 
> 

Here is another update to fix a typo:

+-      if (fnmatch (expr->pattern, sym, 0) == 0)
++      if (fnmatch (expr->pattern, s, 0) == 0)

Otherwise, extern "C++" won't work.


H.J.

Attachment: binutils-vers-glob-3.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]