This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] ld testsuite cleanup for hppa*-*-linux* andhppa64-*-hpux*
- From: Nick Clifton <nickc at redhat dot com>
- To: "John David Anglin" <dave at hiauly1 dot hia dot nrc dot ca>
- Cc: binutils at sources dot redhat dot com
- Date: Sat, 04 Oct 2003 10:38:47 +0100
- Subject: Re: [PATCH] ld testsuite cleanup for hppa*-*-linux* andhppa64-*-hpux*
- References: <200309112134.h8BLYDCn009315@hiauly1.hia.nrc.ca>
Hi Dave,
> The enclosed patch fixes a number of ld testsuite problems on
> hppa*-*-linux* and hppa64-*-hpux*. As the change to
> ld-elfvsb/main.c affects all ports, it needs review. Any other
> comments are welcome.
> 2003-09-11 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
>
> * configure.host (HOSTING_LIBS): Define for hppa*-*-linux*.
> * ld-elfvsb/elfvsb.exp: xfail non-pic shared library tests on
> hppa*-*-linux* and hppa*64*-*-hpux*.
> * ld-elfvsb/main.c (main_visibility_check): Cast value returned by
> visibility_funptr () to a function pointer.
> * ld-shared/shared.exp: xfail shared (non PIC), shared (non PIC, load
> offset), and shared (PIC main, non PIC so) tests on hppa*64*-*-hpux*
> and hppa*-*-linux*.
Approved - please apply.
> Index: testsuite/ld-elfvsb/main.c
> static int
> main_visibility_check ()
> {
> - return visibility_funptr () != visibility;
> + return (int (*) (void)) visibility_funptr () != visibility;
> }
Given that we are now using ISO-C all of this file could benefir from
being updated. Also with the case above, I would recommend adding
some parentheses to show what is being cast (ie the variable
visibility_funptr and not the result of the comparison).
Cheers
Nick