This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: A typo in elfNN_ia64_choose_gp?
On Wed, Sep 10, 2003 at 10:01:26AM -0700, H. J. Lu wrote:
> On Wed, Sep 10, 2003 at 05:42:30PM +0200, Andreas Schwab wrote:
> > "H. J. Lu" <hjl@lucon.org> writes:
> >
> > > + || (hdr->sh_flags | SHF_ALLOC) == 0)
> >
> > This can never be true.
>
> You are right. I only need to check SHT_PROGBITS and SHT_NOBITS.
SHF_ALLOC is 2 and (anyvalue | 2) == 0 is always false.
> > > + if (hdr->sh_flags | SHF_IA_64_SHORT)
> >
> > This is always true.
> >
>
> I don't think so. You have to use .sbss/.sdata or 's' to make a section
> SHF_IA_64_SHORT. But there is a bug in elfNN_ia64_special_sections.
> Sections started with ".sbss" or ".sdata" should be marked as
> SHF_IA_64_SHORT.
You wanted to write & SHF_IA_64_SHORT probably.
SHF_IA_64_SHORT is 0x10000000 and if (anyvalue | 0x10000000)
is always true.
Jakub