Re: patch: ".unreq" pseudo op for ARM

[Nick Clifton <nickc at redhat dot com>]

Hi Pete,

> Attached is a patch to gas/config/tc-arm.c adding support for a
> pseudo op ".unreq", which undoes definitions created with ".req".
> I needed this for some GCC inline assembly code that needs to
> be instantiated more than once.  It would probably be useful
> to create similar a similar operation ".unequiv" as well.

Thanks very much for submitting this patch.  There are a couple of
problems with it however:

  * We need an FSF copyright assignment to be completed before it can
    be accepted.  (Since the patch is adding a new feature, it cannot
    be consider to be trivial).

  * A patch should always be accompanied by a ChangeLog entry.  Also
    in the case of a patch that adds a new feature the documentation
    should be updated as well.  In this the documentation is the file
    gas/doc/c-arm.texi and the news file gas/NEWS.

  * The code in the patch should follow the GNU Coding Standard.
  
    In particular curly braces should be on a line of their own,
    rather than at the end of the preceding line:
    
                 if (*name) {
     should be
                 if (*name)
                   {
     and 
                 } else as_bad .....
     should be
                 }
               else
                 as_bad .....
     
I do hope that you will decide to obtain a copyright assignment and
resubmit the patch as I would certainly like to add it to the sources.

Cheers
        Nick