This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch RFA] revisit MIPS warning re: global symbols asbranch targets.


At Tue, 1 Jul 2003 23:15:44 +0200, Thiemo Seufer wrote:
> cgd@broadcom.com wrote:
> [snip]
> > --- config/tc-mips.c	30 Jun 2003 21:54:19 -0000	1.224
> > +++ config/tc-mips.c	1 Jul 2003 17:21:54 -0000
> > @@ -11059,8 +11059,9 @@ mips_validate_fix (struct fix *fixP, ase
> >  	{
> >  	  symbolS *sym = fixP->fx_addsy;
> >  
> > -	  as_warn_where (fixP->fx_file, fixP->fx_line,
> > -			 _("Pretending global symbol used as branch target is local."));
> > +	  if (mips_pic != NO_PIC)
> > +	    as_warn_where (fixP->fx_file, fixP->fx_line,
> > +			   _("Pretending global symbol used as branch target is local."));
> 
> if (mips_pic == SVR4_PIC) is probably enough.

Is that "approved if you make that change and test it"?  or other?
8-)


cgd


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]