This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [discussion/patch] use mkstemps/mkdtemps instead of mktemp.
- From: Muthukumar Ratty <muthu at iqmail dot net>
- To: DJ Delorie <dj at delorie dot com>
- Cc: <binutils at sources dot redhat dot com>, <amodra at bigpond dot net dot au>, <hp at bitrange dot com>, <ian at airs dot com>, <simonb at wasabisystems dot com>, <berndj at prism dot co dot za>, <ac131313 at redhat dot com>
- Date: Thu, 3 Jul 2003 15:40:11 -0700 (PDT)
- Subject: Re: [discussion/patch] use mkstemps/mkdtemps instead of mktemp.
Hi DJ,
> Logistics of the patch aside, I have a few comments:
>
> libiberty patches must also be sent to gcc-patches@gcc.gnu.org
Once its oked here I will send it there too.
>
> > /* Copyright (C) 1991, 1992, 1996, 1998 Free Software Foundation, Inc.
>
> These years are obviously wrong.
I will change that.
>
> > #if defined (_WIN32) && !defined (__CYGWIN32__)
>
> I believe the correct symbol to test is __CYGWIN__
>
This one, I got from objcopy.c. I dont know what the correct symbol is.
> > Generate a unique temporary file name from @var{template}.
>
> A unique temporary *directory* name.
>
> > /* The file does not exist. */
>
> file -> directory
> does -> did
>
Sorry, cut and paste error :)
Muthu