RE: [PATCH] New BFD vector for QNX Neutrino MIPS

[Jeff Baker <jbaker at qnx dot com>]

With this patch I was just trying to get the new vector committed.  I was
using the two new files as place holders for the ones I haven't finished
yet.  I was working under the 'smaller patches are better' pretense, but I
have no problem submitting a big one later.  It's all the same to me.

I suppose I should take this opportunity to make sure I'm headed down the
right path though.  Our copy of the binutils source (2.12.1) has lots of
changes to the code in elf32-mips.c.  My interpretation of the correct way
to include our changes was to mimic what was done in elf32-or32.c &&
elf32-dlx.c (&& ... && ... && ...).

I don't know if there's a naming convention for vectors, so I just picked
bfd_elf32_littlemipsnto_vec (bfd_elf32_bigmipsnto_vec) in elf32-mipsnto.c.
Again, it's all the same to me so if anyone would prefer something else I'll
just change it.

> -----Original Message-----
> From: Eric Christopher [mailto:echristo@redhat.com]
> Sent: June 6, 2003 5:34 PM
> To: Daniel Jacobowitz
> Cc: Jeff Baker; binutils@sources.redhat.com
> Subject: Re: [PATCH] New BFD vector for QNX Neutrino MIPS
> 
> On Fri, 2003-06-06 at 12:49, Daniel Jacobowitz wrote:
> > On Fri, Jun 06, 2003 at 03:30:55PM -0400, Jeff Baker wrote:
> > > I'm not entirely done with the QNX MIPS support yet, but I figured I'd
> get
> > > my foot in the door by submitting the addition of a new vector to
> support
> > > it.
> > >
> > > The two new files mentioned (elf32-mipsnto.c && elfxx-mipsnto.c) are
> > > currently just copies of elf32-mips.c and elfxx-mips.c, respectively.
> I
> > > will submit my changes for those in a separate patch.
> >
> > If you are duplicating twelve thousand lines of BFD code to add NTO
> > support, then you're not doing it the right way.  Sorry.
> 
> Agreed.
> 
> Jeff: What are you trying to do?
> 
> -eric
> 
> --
> Eric Christopher <echristo@redhat.com>