This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Binutils 2.14 prerelease 2


Daniel Jacobowitz wrote:
I would appreciate any and all testing of this prerelease.  It will become
binutils 2.14 in about a week unless a showstopper is found.

Hi,

While waiting for approval for http://sources.redhat.com/ml/binutils/2003-05/msg00860.html
I also have discovered a bug in the coff-tic4x.c file. It contains invalid initialization of the coff swap table for the COFF0 and COFF1 targets. This bug is also present in the upcoming 2.14 release


Attached fix.


BTW Do I need approval as a maintainer to check this thing into the 2.14 branch when a release is close to final release like this? Do we operate with freezes in the binutils tree?



Regards,




bfd/ChangeLog:
2003-06-02  Svein E. Seldal  <Svein.Seldal@solidas.com>

        * coff-tic4x.c: Fixed error in placement of member
        initialization of the ticoff0_swap_table and the
        ticoff1_swap_table structs.
? build.inst.tic4x
Index: bfd/coff-tic4x.c
===================================================================
RCS file: /cvs/src/src/bfd/coff-tic4x.c,v
retrieving revision 1.5
diff -c -3 -p -r1.5 coff-tic4x.c
*** bfd/coff-tic4x.c	4 Apr 2003 08:15:13 -0000	1.5
--- bfd/coff-tic4x.c	3 Jun 2003 07:26:21 -0000
*************** static const bfd_coff_backend_data ticof
*** 299,304 ****
--- 299,305 ----
  #else
    FALSE,
  #endif
+   COFF_DEFAULT_SECTION_ALIGNMENT_POWER,
  #ifdef COFF_FORCE_SYMBOLS_IN_STRINGS
    TRUE,
  #else
*************** static const bfd_coff_backend_data ticof
*** 309,315 ****
  #else
    2,
  #endif
-   COFF_DEFAULT_SECTION_ALIGNMENT_POWER,
    coff_SWAP_filehdr_in, coff_SWAP_aouthdr_in, coff_SWAP_scnhdr_in,
    coff_SWAP_reloc_in, ticoff0_bad_format_hook, coff_set_arch_mach_hook,
    coff_mkobject_hook, styp_to_sec_flags, coff_set_alignment_hook,
--- 310,315 ----
*************** static const bfd_coff_backend_data ticof
*** 340,345 ****
--- 340,346 ----
  #else
    FALSE,
  #endif
+   COFF_DEFAULT_SECTION_ALIGNMENT_POWER,
  #ifdef COFF_FORCE_SYMBOLS_IN_STRINGS
    TRUE,
  #else
*************** static const bfd_coff_backend_data ticof
*** 350,356 ****
  #else
    2,
  #endif
-   COFF_DEFAULT_SECTION_ALIGNMENT_POWER,
    coff_SWAP_filehdr_in, coff_SWAP_aouthdr_in, coff_SWAP_scnhdr_in,
    coff_SWAP_reloc_in, ticoff1_bad_format_hook, coff_set_arch_mach_hook,
    coff_mkobject_hook, styp_to_sec_flags, coff_set_alignment_hook,
--- 351,356 ----

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]