This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] MIPS ld: Fix global GOT symbol count for -Bsymbolic links


On Tue, May 27, 2003 at 03:33:08AM +0200, Thiemo Seufer wrote:
> Hello All,
> 
> this fixes a linker bug which distorts the global GOT symbol count
> by counting some globals as forced local. It got only triggered in
> -Bsymbolic links.

>From the context, I'm guessing that this fixes the OpenSSL issue.  Is
that right?

By the way, your mailer is creating invalid Mail-Followup-To headers
without a hostname.

> 2003-05-27  Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>
> 
> 	/bfd/ChangeLog
> 	* elfxx-mips.c: Don't force symbols unconditionally.
> 
> 
> --- source-orig/bfd/elfxx-mips.c	Sun May 25 09:20:23 2003
> +++ source/bfd/elfxx-mips.c	Sun May 25 09:55:20 2003
> @@ -7798,10 +7798,10 @@ _bfd_mips_elf_hide_symbol (info, entry, 
>    h = (struct mips_elf_link_hash_entry *) entry;
>    if (h->forced_local)
>      return;
> -  h->forced_local = TRUE;
> +  h->forced_local = force_local;
>  
>    dynobj = elf_hash_table (info)->dynobj;
> -  if (dynobj != NULL)
> +  if (dynobj != NULL && force_local)
>      {
>        got = mips_elf_got_section (dynobj, FALSE);
>        g = mips_elf_section_data (got)->u.got_info;
> 

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]