This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: i860 tests causing all other targets to abort testsuite runs
- From: Jason Eckhardt <jle at owlnet dot rice dot edu>
- To: <hp at bitrange dot com>
- Cc: <binutils at sources dot redhat dot com>
- Date: Fri, 23 May 2003 11:45:16 -0500 (CDT)
- Subject: Re: i860 tests causing all other targets to abort testsuite runs
H-P wrote:
>
>On Fri, 23 May 2003, Richard Earnshaw wrote:
>> The i860.exp control file was calling exit when the target wasn't an i860.
>> That causes the whole testsuite run to be abandoned -- not a good idea.
>>
>> Committed as obvious.
>
>Thanks for catching this. (Doesn't anyone study other .exp
>files when writing their own?)
>
Thanks for fix (but not the editorial). Yes, I did study other
.exp files and my original patch followed what ia64 did (and others).
But it was suggested that I instead change it to exit when the target
was not i860 (which I took literally as "exit" instead of "return").
Sorry for the confusion. The original was:
***************
*** 0 ****
--- 1,28 ----
+ # i860 assembler testsuite.
+
+ if [istarget i860-*-*] {
+ run_dump_test "bte"
+ run_dump_test "bitwise"
+ run_dump_test "fldst01"
+ run_dump_test "fldst02"
+ run_dump_test "fldst03"
+ run_dump_test "fldst04"
+ run_dump_test "fldst05"
+ run_dump_test "fldst06"
+ run_dump_test "fldst07"
+ run_dump_test "fldst08"
+ run_dump_test "form"
+ run_dump_test "iarith"
+ run_dump_test "ldst01"
+ run_dump_test "ldst02"
+ run_dump_test "ldst03"
+ run_dump_test "ldst04"
+ run_dump_test "ldst05"
+ run_dump_test "ldst06"
+ run_dump_test "pfam"
+ run_dump_test "pfmam"
+ run_dump_test "pfsm"
+ run_dump_test "pfmsm"
+ run_dump_test "regress01"
+ run_dump_test "shift"
+ }