Re: PATCH: Fix ELF visibility handling

["H. J. Lu" <hjl at lucon dot org>]

On Mon, May 19, 2003 at 05:38:02PM -0700, H. J. Lu wrote:
> On Tue, May 20, 2003 at 12:19:19AM +0200, Jakub Jelinek wrote:
> > On Wed, Apr 09, 2003 at 09:22:52AM -0700, H. J. Lu wrote:
> > > 2003-04-01  H.J. Lu <hjl@gnu.org>
> > > 
> > > 	(elf_link_output_extsym): Warn if a forced local symbol is
> > > 	referenced from dynamic objects. Make non-weak undefined symbol
> > > 	with non-default visibility a fatal error.
> > 
> > This change broke static linking with hidden common symbols
> > (testcase included in the patch below).
> 
> I don't think it works with dynamic linking either. I found another
> bug. I will post a testcase and a patch later.
> 
> > Any reason why you use h->root.type != bfd_link_hash_undefweak
> > which can well be a normal bfd_link_hash_defined symbol?
> 
> I have an old patch to fix a related problem:
> 
> http://sources.redhat.com/ml/binutils/2003-03/msg00080.html
> 
> in a different way. Then I changed it and forgot to update another
> patch. That is what happened when you had so many patches on top
> of each other.
> 

Here is the new patch.


H.J.

Attachment: binutils-vsb-3.patch
Description: Text document