This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: RFC: Fix ia64 visibility
On Wed, May 07, 2003 at 11:09:32AM -0700, Richard Henderson wrote:
> On Tue, May 06, 2003 at 04:04:02PM -0700, H. J. Lu wrote:
> > - dyn_i->want_plt2 = 0;
> > + {
> > + dyn_i->want_plt2 = 0;
> > + dyn_i->want_plt = 0;
> > + }
>
> You've not checked that there are no PLTOFF relocations.
I thought it was checked by the want_pltoff field.
>
> > - if (dynamic_symbol_p)
> > + if (dynamic_symbol_p
> > + && ELF_ST_VISIBILITY (h->other) == STV_DEFAULT)
>
> dynamic_symbol_p has already checked visibility. Why
> would we need to do it again?
dynamic_symbol_p only checks STV_INTERNAL and STV_HIDDEN. For certain
relocation types, there is no need for dynamic symbol lookup even for
STV_PROTECTED. I can use ELF_ST_VISIBILITY (h->other) != STV_PROTECTED.
But I thought ELF_ST_VISIBILITY (h->other) == STV_DEFAULT might help
compiler a little bit. Maybe I should put a comment there.
H.J.