This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: RFC: Fix ia64 visibility
- From: Richard Henderson <rth at redhat dot com>
- To: "H. J. Lu" <hjl at lucon dot org>
- Cc: binutils at sources dot redhat dot com
- Date: Wed, 7 May 2003 11:09:32 -0700
- Subject: Re: RFC: Fix ia64 visibility
- References: <20030506160402.B11085@lucon.org>
On Tue, May 06, 2003 at 04:04:02PM -0700, H. J. Lu wrote:
> - dyn_i->want_plt2 = 0;
> + {
> + dyn_i->want_plt2 = 0;
> + dyn_i->want_plt = 0;
> + }
You've not checked that there are no PLTOFF relocations.
> - if (dynamic_symbol_p)
> + if (dynamic_symbol_p
> + && ELF_ST_VISIBILITY (h->other) == STV_DEFAULT)
dynamic_symbol_p has already checked visibility. Why
would we need to do it again?
r~