This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [mips patch rfa] slight tweak to vr5400 "mul" opcode
- From: Richard Sandiford <rsandifo at redhat dot com>
- To: cgd at broadcom dot com
- Cc: binutils at sources dot redhat dot com, echristo at redhat dot com
- Date: 05 Apr 2003 08:47:42 +0100
- Subject: Re: [mips patch rfa] slight tweak to vr5400 "mul" opcode
- References: <yov5llyp98bl.fsf@broadcom.com>
I notice you've cc'ed me on this one. ;) Not really my work but...
cgd at broadcom dot com writes:
> I've been going through and trying to do some more testsuite
> improvements, and i noticed that the vr5400 3-operand "mul" opcode,
> unlike the rest of the "mul" opcode entries, _requires_ 3 operands.
>
> i.e., normally:
>
> mul foo, bar
>
> means the same as:
>
> mul foo, foo, bar
>
> but for vr5400 you _must_ use the latter form. I couldn't find any
> documentation to support this requirement.
...how useful is it to hide the duplicated operand? IMO it's very
easily confused with:
mult foo, bar
which of course is completely different.
On the other hand, I don't think there's any reason why the vr5432 case
should be special. It might as well be consistent with mips32 & mips64.
So your patch looks OK to me.
Richard