This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Re: readelf -D --reloc bug

Hi H.J.

> 2003-03-31  H.J. Lu <hjl at gnu dot org>
> 
> 	* readelf.c (dynamic_relocations): New.
> 	(process_relocs) Properly handle dynamic relocation.
> 	(process_dynamic_segment): Fill relocation elements in
> 	dynamic_info.

Approved please apply - but with caveat.

Rather than using a fixed constant NUM_DYNAMIC_RELOCATIONS, please
just make the dynamic_relocations array unsized and compute the size
in the for loop.  (You could even use the ARRAY_SIZE macro from
libiberty.h).

Cheers
        Nick
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]