This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Bug in xsym.c ?

From: Nick Clifton <nickc at redhat dot com>
To: Elias Athanasopoulos <elathan at phys dot uoa dot gr>
Cc: kdienes at apple dot com, binutils at sources dot redhat dot com
Date: 12 Mar 2003 09:58:24 +0000
Subject: Re: Bug in xsym.c ?
References: <m3d6l6p4iy.fsf@workshop.nickc.cambridge.redhat.com><20030308215121.A9614@neutrino.particles.org>

Hi Elias,

> I believe the test should be made against the 'offset' variable.
> 
> Although this is not a proof:
> 
> [anteater at neutrino bfd]$ grep bfd_sym_fetch_type_information_table_entry *.c
> xsym.c:bfd_sym_fetch_type_information_table_entry (abfd, entry, offset)
> xsym.c:  if (bfd_sym_fetch_type_information_table_entry (abfd, entry, tindex) < 0)
> xsym.c:   if (bfd_sym_fetch_type_information_table_entry (abfd, &entry, index) < 0)
> 
> As I understand it, 'offset' should have been named 'index'.

Seems fair enough.  Klee has not responded, so I have checked in a
patch to rename 'entry' to 'offset'.

Cheers
         Nick

2003-03-12  Nick Clifton  <nickc at redhat dot com>

	* xsym.c (bfd_sym_fetch_type_information_table_entry): Change
	'entry' to 'offset' in test for zero value.

References:
- Bug in xsym.c ?
  - From: Nick Clifton
- Re: Bug in xsym.c ?
  - From: Elias Athanasopoulos

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]