This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] MIPS gas: Remove non-BFD_ASSEMBLER cases


Thiemo Seufer wrote:
> Hello All,
> 
> the MIPS gas is always a BFD Assembler.

.. and a bit of code cleanup is good also.


Thiemo


2003-03-03  Thiemo Seufer <seufer at csv dot ica dot uni-stuttgart dot de>

	/gas/ChangeLog
	* config/tc-mips.c (s_mips_end): Remove !BFD_ASSEMBLER case.
	(s_mips_ent): Likewise.


--- source-orig/gas/config/tc-mips.c	Mon Mar  3 00:23:15 2003
+++ source/gas/config/tc-mips.c	Mon Mar  3 00:34:27 2003
@@ -14238,7 +14238,6 @@ s_mips_end (x)
      int x ATTRIBUTE_UNUSED;
 {
   symbolS *p;
-  int maybe_text;
 
   /* Following functions need their own .frame and .cprestore directives.  */
   mips_frame_reg_valid = 0;
@@ -14252,19 +14251,7 @@ s_mips_end (x)
   else
     p = NULL;
 
-#ifdef BFD_ASSEMBLER
-  if ((bfd_get_section_flags (stdoutput, now_seg) & SEC_CODE) != 0)
-    maybe_text = 1;
-  else
-    maybe_text = 0;
-#else
-  if (now_seg != data_section && now_seg != bss_section)
-    maybe_text = 1;
-  else
-    maybe_text = 0;
-#endif
-
-  if (!maybe_text)
+  if ((bfd_get_section_flags (stdoutput, now_seg) & SEC_CODE) == 0)
     as_warn (_(".end not in text section"));
 
   if (!cur_proc_ptr)
@@ -14336,7 +14323,6 @@ s_mips_ent (aent)
      int aent;
 {
   symbolS *symbolP;
-  int maybe_text;
 
   symbolP = get_symbol ();
   if (*input_line_pointer == ',')
@@ -14346,19 +14332,7 @@ s_mips_ent (aent)
       || *input_line_pointer == '-')
     get_number ();
 
-#ifdef BFD_ASSEMBLER
-  if ((bfd_get_section_flags (stdoutput, now_seg) & SEC_CODE) != 0)
-    maybe_text = 1;
-  else
-    maybe_text = 0;
-#else
-  if (now_seg != data_section && now_seg != bss_section)
-    maybe_text = 1;
-  else
-    maybe_text = 0;
-#endif
-
-  if (!maybe_text)
+  if ((bfd_get_section_flags (stdoutput, now_seg) & SEC_CODE) == 0)
     as_warn (_(".ent or .aent not in text section."));
 
   if (!aent && cur_proc_ptr)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]