This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: PATCH : H8300 Simulator File I/O Implementation
- From: Kazu Hirata <kazu at cs dot umass dot edu>
- To: dvenkat at noida dot hcltech dot com
- Cc: gdb-patches at sources dot redhat dot com, binutils at sources dot redhat dot com
- Date: Sat, 30 Nov 2002 13:00:27 -0500 (EST)
- Subject: Re: PATCH : H8300 Simulator File I/O Implementation
- References: <E04CF3F88ACBD5119EFE00508BBB212105D59B4C@exch-01.noida.hcltech.com>
Hi Venky,
You might want to send your patch to newlib@sources.redhat.com as
well, possibly after separating the patch for individual projects
(binutils, newlib, and gdb-patches)!?
! /* And a jsr to these locations are turned into magic traps. */
if (dst->opcode == O (O_JSR, SB))
{
! if (dst->src.literal == 0xc5)
This may be up to your preference, but what about "switch (dst->src.literal)"?
! /* Setting filename_ptr to first argument of open */
! filename_ptr = cpu.regs[0];
I think the GNU coding standard prefers a complete sentence (well,
except the subject) ending with a period and two spaces like
/* Set filename_ptr to the first argument of open. */
! /* Allocating space for the filename */
! filename = (char *)malloc(sizeof(char) * len);
Do you free this filename somewhere?
Thanks,
Kazu Hirata