This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Latest readelf change broke (generally) readelf -s
- From: Nick Clifton <nickc at redhat dot com>
- To: binutils at sources dot redhat dot com
- Date: 07 Nov 2002 09:42:42 +0000
- Subject: Re: Latest readelf change broke (generally) readelf -s
- References: <200211061759.gA6HxadF030356@ignucius.axis.se>
Hi Guys,
> I don't really see the need for readelf formatting changes like
> this, corresponding to this snippet from ld.log for readelf -s:
>
> regexp "^ 1: 00000000 0 SECTION LOCAL DEFAULT 1 $"
> line " 1: 00000000 0 SECTION LOCAL DEFAULT 0x0001 "
Doh! This was my fault. I actually applied Hiroyuki's patch, tested
it, found no new failures, committed it, and then noticed that I had
omitted the change from decimal to hex for unknown symbol types. So I
quickly applied that part of the patch, checked that readelf built,
but forgot to retest. Doh!
Oh well, I have undone that part of the patch, so the binutils and ld
testsuites (for x86 natives at least) now run with no unexpected
failures.
Cheers
Nick
2002-11-07 Nick Clifton <nickc@redhat.com>
* readelf.c (get_symbol_index_type): Revert part of previous
patch: Display unknown symbol types in decimal, not hex.
PS. I also fixed a minor problem with the new PE fastcall support
which was causing an ERROR failure when the x85 linker testsuite was
run. The new ld-fastcall test was being run for this target, but the
assembler source file involved uses an '@' symbol which is not valid
outside of PE environments. So I fixed that too.
2002-11-07 Nick Clifton <nickc@redhat.com>
* ld-fastcall/fastcall.exp: Only run tests for PE type x86
targets.