This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
PATCH: Fix dependencies in bfd
On Mon, Oct 28, 2002 at 10:09:44AM -0800, H. J. Lu wrote:
> While working on ELFOSABI_QNX, I found 2 incorrect dependencies in bfd:
>
> # When compiling archures.c and targets.c, supply the default target
> # info from configure.
>
> targets.lo: targets.c config.status
> $(LIBTOOL) --mode=compile $(COMPILE) -c $(TDEFAULTS) $(srcdir)/targets.c
>
> archures.lo: archures.c config.status
> $(LIBTOOL) --mode=compile $(COMPILE) -c $(TDEFAULTS) $(srcdir)/archures.c
>
> The problem is $(TDEFAULTS) comes from Makefile, not config.status.
> Makefile, including TDEFAULTS, can change when config.status is
> unchanged.
I'd like to check in this patch shortly if there is no objection.
H.J.
---
2002-10-28 H.J. Lu <hjl@gnu.org>
* Makefile.am (targets.lo): Depend on Makefile instead of
config.status.
(archures.lo): Likewise.
* Makefile.in: Regenerated.
--- bfd/Makefile.am.vec Wed Oct 23 23:33:56 2002
+++ bfd/Makefile.am Mon Oct 28 13:56:20 2002
@@ -654,10 +654,10 @@ targmatch.h: config.bfd targmatch.sed
# When compiling archures.c and targets.c, supply the default target
# info from configure.
-targets.lo: targets.c config.status
+targets.lo: targets.c Makefile
$(LIBTOOL) --mode=compile $(COMPILE) -c $(TDEFAULTS) $(srcdir)/targets.c
-archures.lo: archures.c config.status
+archures.lo: archures.c Makefile
$(LIBTOOL) --mode=compile $(COMPILE) -c $(TDEFAULTS) $(srcdir)/archures.c
elf32-target.h : elfxx-target.h
--- bfd/Makefile.in.vec Wed Oct 23 23:33:58 2002
+++ bfd/Makefile.in Mon Oct 28 13:58:25 2002
@@ -1201,10 +1201,10 @@ targmatch.h: config.bfd targmatch.sed
# When compiling archures.c and targets.c, supply the default target
# info from configure.
-targets.lo: targets.c config.status
+targets.lo: targets.c Makefile
$(LIBTOOL) --mode=compile $(COMPILE) -c $(TDEFAULTS) $(srcdir)/targets.c
-archures.lo: archures.c config.status
+archures.lo: archures.c Makefile
$(LIBTOOL) --mode=compile $(COMPILE) -c $(TDEFAULTS) $(srcdir)/archures.c
elf32-target.h : elfxx-target.h