This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: K&R patch for binutils bfd directory


> OK.  It offends my sense of style to see something like
> 
> 	copy = (boolean) (! finfo->info->keep_memory);

Yes, it's definitely ugly especially since the underlying implementation
is int.  I guess the thought was that enums have only a limited set of
values, so when an int is assigned to enum there should be a warning since
the value might not be in the set.

Dave
-- 
J. David Anglin                                  dave.anglin@nrc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6605)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]