This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: K&R patch for binutils bfd directory
- From: "John David Anglin" <dave at hiauly1 dot hia dot nrc dot ca>
- To: amodra at bigpond dot net dot au (Alan Modra)
- Cc: binutils at sources dot redhat dot com
- Date: Thu, 24 Oct 2002 22:35:14 -0400 (EDT)
- Subject: Re: K&R patch for binutils bfd directory
> OK. It offends my sense of style to see something like
>
> copy = (boolean) (! finfo->info->keep_memory);
Yes, it's definitely ugly especially since the underlying implementation
is int. I guess the thought was that enums have only a limited set of
values, so when an int is assigned to enum there should be a warning since
the value might not be in the set.
Dave
--
J. David Anglin dave.anglin@nrc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6605)