Re: [Patch] sh64: Fix gas testsuite expected output

["Stephen Clarke" <stephen dot clarke at earthling dot net>]

From: "Stephen Clarke"
Sent: Monday, October 14, 2002 10:05 PM
>
> From: "H. J. Lu"
> Sent: Monday, October 14, 2002 9:38 PM
> 
> > [long list of further failures]
> 
> I don't get any of these.  I'll try to work out why.
> It could help if you'd send me the gas.log file.

It looks like these failures are because of:

.../objdump: dump.o: File format is ambiguous
.../objdump: Matching formats: elf32-sh64big-linux elf32-sh64

and that's because both sh-linux and sh64-linux targets
are enabled, i.e. binutils is configured with
--enable-targets=...,sh-linux,sh64-linux,...

The definition of sh-*-linux* in config.bfd is:

sh-*-linux*)
    targ_defvec=bfd_elf32_shblin_vec
    targ_selvecs=bfd_elf32_shlin_vec
#ifdef BFD64
    targ_selvecs="${targ_selvecs} bfd_elf32_sh64_vec bfd_elf32_sh64l_vec bfd_elf64_sh64_vec bfd_elf64_sh64l_vec"
#endif

This includes some "sh64" target vectors, which then cannot be distinguished
from sh64-linux target vectors.

I'm not sure why sh-*-linux* should include sh64 target vectors.  My understanding
of "sh" is that it is supposed to be 32-bit sh targets only, and it
should avoid any overhead required for 64-bit targets.

I suggest that the sh64 vectors are removed from sh-*-linux*.
What do the maintainers think?

(Aside: as mentioned in http://sources.redhat.com/ml/binutils/2002-08/msg00069.html
this particular use of ifdef BFD64 has no effect in config.bfd: the sh64 vectors are
built into an sh-linux target whether or not --enable-64-bit-bfd is specified.  I intended to
submit a patch to strip out the ineffectual ifdefs, but forgot.)

Steve.


__________________________________________________
Do You Yahoo!?
Sign up for SBC Yahoo! Dial - First Month Free
http://sbc.yahoo.com