Re: [Patch] sh64: Fix gas testsuite expected output

[Hans-Peter Nilsson <hp at bitrange dot com>]

On Wed, 2 Oct 2002, Stephen Clarke wrote:

While I have your attention, can you please do some official
check regarding the TLS ELF reloc numbers that Kojima-san
proposed?

> From: "H. J. Lu"
> Sent: Wednesday, October 02, 2002 4:08 PM
>
>
> > Is sh64-linux a supported Linux target? If yes, I can add it to my
> > binutils test target. I already test sh-linux, adding sh64-linux won't
> > be a problem.
>
> Not yet ... there's a patch at
> http://sources.redhat.com/ml/binutils/2002-09/msg00048.html
> waiting to be reviewed.

That patch is ok.

> This would need sh64 gas and ld testsuite fixes too, see
> http://sources.redhat.com/ml/binutils/2002-09/msg00049.html

Ok.

> http://sources.redhat.com/ml/binutils/2002-09/msg00050.html

But for one thing (leading to some other changes), the patch is
ok:

Index: ld/testsuite/ld-sh/sh.exp
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-sh/sh.exp,v
retrieving revision 1.8
diff -u -c -3 -p -r1.8 sh.exp
*** ld/testsuite/ld-sh/sh.exp   8 Feb 2002 06:49:55 -0000
1.8
--- ld/testsuite/ld-sh/sh.exp   30 Aug 2002 00:51:57 -0000
*************** if ![istarget sh*-*-*] {
*** 25,31 ****
      return
  }

! if [istarget sh64-*-elf] {
      # relaxing not supported on sh64 yet.
      return
  }
--- 25,32 ----
      return
  }

! if { ([istarget sh64-*-elf]
!       || [istarget sh64*-*-linux*])} {
      # relaxing not supported on sh64 yet.
      return
  }

I'd rather you tweak the target specifiers on the tests:
#targets: sh-*-* shl*-*-* shb*-*-*
in each *.d should suffice.

>
> I couldn't miss this opportunity to nag the maintainers could I :-)

Where's Joern these days?  Doesn't he work on SH stuff?

brgds, H-P