This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] MIPS: IRIX .section support
- From: Nick Clifton <nickc at redhat dot com>
- To: Stan Cox <scox at redhat dot com>
- Cc: binutils at sources dot redhat dot com
- Date: 22 Aug 2002 17:34:29 +0100
- Subject: Re: [PATCH] MIPS: IRIX .section support
- References: <y0x8z3cge14.fsf_-_@scox.rdu.redhat.com>
Hi Stan,
> are handled by calling obj_elf_section. The IRIX forms are handled by
> calling obj_elf_change_section. Currently this is a static routine,
> called by only by obj_elf_section.
>
> * config/obj-elf.c (obj_elf_change_section): Make non-static.
This is almost OK, except that instead of just changing the static
prototype in obj-elf.c:
--- config/obj-elf.c 7 Jun 2002 14:57:50 -0000 1.52
+++ config/obj-elf.c 12 Aug 2002 16:37:28 -0000
@@ -78,5 +78,5 @@ static void obj_elf_weak PARAMS ((int));
static void obj_elf_local PARAMS ((int));
static void obj_elf_visibility PARAMS ((int));
-static void obj_elf_change_section
+void obj_elf_change_section
PARAMS ((const char *, int, int, int, const char *, int, int));
Please move the entire prototype to obj-elf.h and make it an "extern
void ..." declaration.
With this change your patch is approved.
Cheers
Nick