This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
[RFA/PATCH] Fix recognition of NT_PRXFREG notes
- From: Mark Kettenis <kettenis at chello dot nl>
- To: binutils at sources dot redhat dot com
- Cc: gdb-patches at sources dot redhat dot com
- Date: Thu, 4 Jul 2002 17:03:22 +0200 (CEST)
- Subject: [RFA/PATCH] Fix recognition of NT_PRXFREG notes
After Alan's 2002-06-25 change some tests in GDB's testsuite have been
failing on Linux. Turns out the current code that reads NT_PRXFREG
notes expects note->namesz to be 5, but with the trailing 0, the
length of "LINUX" is 6. Turns out the Linux kernel doesn't include
the trailing 0 in the name size. According to the Systemm V ABI the
trailing 0 should be included, so Alan's change is correct and Linux
is wrong here. But since changing the Linux kernel isn't going to
happen overnight, I propose the attached fix.
Ok to check this in?
Mark
Index: ChangeLog
from Mark Kettenis <kettenis@gnu.org>
* elf.c (elfcore_grok_note): Fix recognition of NT_PRXFREG notes.
Index: elf.c
===================================================================
RCS file: /cvs/src/src/bfd/elf.c,v
retrieving revision 1.152
diff -u -p -r1.152 elf.c
--- elf.c 4 Jul 2002 13:26:30 -0000 1.152
+++ elf.c 4 Jul 2002 14:54:36 -0000
@@ -6718,8 +6718,7 @@ elfcore_grok_note (abfd, note)
#endif
case NT_PRXFPREG: /* Linux SSE extension */
- if (note->namesz == 5
- && ! strcmp (note->namedata, "LINUX"))
+ if (strncmp (note->namedata, "LINUX", 5) == 0)
return elfcore_grok_prxfpreg (abfd, note);
else
return true;