This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] nm size/value output fix.
- From: Nick Clifton <nickc at cambridge dot redhat dot com>
- To: Elias Athanasopoulos <eathan at otenet dot gr>
- Cc: binutils at sources dot redhat dot com
- Date: 13 Jun 2002 18:05:59 +0100
- Subject: Re: [PATCH] nm size/value output fix.
- References: <20020522155416.A1267@neutrino.particles.org><m3u1oxsy4t.fsf@north-pole.nickc.cambridge.redhat.com><20020531210419.B1153@neutrino.particles.org><m3zny7i1b2.fsf@north-pole.nickc.cambridge.redhat.com><20020613133217.J17527@neutrino.particles.org>
Hi Elias,
> Nick, if you have the time, can you verify that the modification below is
> not nonsense?
>
> + /* For elf we have already computed the correct symbol size */
> + if (bfd_get_flavour (abfd) == bfd_target_elf_flavour)
> + ssize = from->size;
> + else
> + ssize = from->size - bfd_section_vma (abfd, bfd_get_section (sym));
Yup this appears to be OK.
> 2002-6-13 Elias Athanasopoulos <eathan@otenet.gr>
>
> * nm.c: Introduce extended_symbol_info structure, in order to hold
> the size of symbols. Print not only the size of the symbols when we
> sort by size, but both size and value.
Approved & applied. (Please note the rewritten ChangeLog entry - this
is the preferred form)
Cheers
Nick