This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] nm size/value output fix.


Hi Elias,

> Nick, if you have the time, can you verify that the modification below is
> not nonsense?
> 
> +      /* For elf we have already computed the correct symbol size */
> +      if (bfd_get_flavour (abfd) == bfd_target_elf_flavour)
> +       ssize = from->size;
> +      else
> +       ssize = from->size - bfd_section_vma (abfd, bfd_get_section (sym));

Yup this appears to be OK.

> 2002-6-13  Elias Athanasopoulos  <eathan@otenet.gr>
> 
> 	* nm.c: Introduce extended_symbol_info structure, in order to hold
> 	the size of symbols. Print not only the size of the symbols when we 
> 	sort by size, but both size and value.

Approved & applied.  (Please note the rewritten ChangeLog entry - this
is the preferred form)

Cheers
        Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]