This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix objdump output formatting


On Mon, May 20, 2002 at 04:49:15AM +0200, Thiemo Seufer wrote:
> If I understood the code correctly, all non-ELF targets determine their
> address size at compile time via BFD64, while ELF targets do this via
> their backend data.

Uh, OK.  I didn't look far enough.

> 	/binutils/ChangeLog
> 	* objdump.c (dump_headers): Fix output formatting for ELF32
> 	architectures in a BFD64 enabled toolchain.

OK then, except that bfd_get_arch_size will call bfd_set_error on
non-ELF targets.  I think calling bfd_set_error is wrong.  A patch to
remove the bfd_set_error call is pre-approved.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]