This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] allow easier overriding of ELF_DYNAMIC_INTERPRETER
- From: "David O'Brien" <obrien at FreeBSD dot org>
- To: Nick Clifton <nickc at cambridge dot redhat dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Wed, 13 Feb 2002 07:55:29 -0800
- Subject: Re: [PATCH] allow easier overriding of ELF_DYNAMIC_INTERPRETER
- Organization: The NUXI BSD group
- References: <20020125234343.A66746@dragon.nuxi.com> <20020126101345.GA24173@rembrandt.csv.ica.uni-stuttgart.de> <20020128114017.A70744@dragon.nuxi.com> <20020128122518.V8364@dr-evil.shagadelic.org> <20020128132808.B72046@dragon.nuxi.com> <m3ofitwrtx.fsf@north-pole.nickc.cambridge.redhat.com>
- Reply-to: obrien at FreeBSD dot org
On Wed, Feb 13, 2002 at 11:20:58AM +0000, Nick Clifton wrote:
> > * elf32-arm.h (ELF_DYNAMIC_INTERPRETER): Only define if not already
> > defined.
>
> I Think that Thiemo is right - it would be better to #undef any prior
> definitions of ELF_DYNAMIC_INTERPRETER rather than providing a
> definition in case there is no default. Please could you change your
> patch to do this instead ?
I am not sure what you are suggesting.
You are suggesting that rather than:
#ifndef ELF_DYNAMIC_INTERPRETER
#define ELF_DYNAMIC_INTERPRETER foo
#endif
the patch become:
#undef ELF_DYNAMIC_INTERPRETER
#define ELF_DYNAMIC_INTERPRETER foo
Correct? If so that still will not allow easy overriding of
ELF_DYNAMIC_INTERPRETER. How about we just move that macro into its own
header? It would be very easy to provide an alternate header via
``configure''.