This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Committed, SH: bfd bits for sh64 on sh-*, shl-* ELF targets. Fix opcodes too.
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: Hans-Peter Nilsson <hp at bitrange dot com>
- Cc: <binutils at sources dot redhat dot com>
- Date: 11 Feb 2002 03:37:10 -0200
- Subject: Re: Committed, SH: bfd bits for sh64 on sh-*, shl-* ELF targets. Fix opcodes too.
- Organization: GCC Team, Red Hat
- References: <Pine.BSF.4.30.0202102333540.82122-100000@dair.pair.com>
On Feb 11, 2002, Hans-Peter Nilsson <hp@bitrange.com> wrote:
> On 11 Feb 2002, Alexandre Oliva wrote:
>> On Feb 10, 2002, Hans-Peter Nilsson <hp@bitrange.com> wrote:
>>
>> > FAIL: ld-sh/shared-1
>>
>> I remember this patch from before, but I thought I had a patch for the
>> testsuite that would fix it. Hmm... Perhaps I failed to contribute
>> it?
> Perhaps not; this has come in after your tweak on "2002/02/02".
So you're saying it was working before? Well, perhaps then changes in
offsets were results of the GOTOFF optimization. Anyway, it appears
that, when I modified the test to reflect the header changes, I
modified the relocation offset but not its addend. Oops :-)
I wonder how you could even think of inviting me to become a
co-maintainer :-(
Here's a patch that fixes the test. Ok to install in the 2.12 branch?
Index: ld/testsuite/ChangeLog
from Alexandre Oliva <aoliva@redhat.com>
* ld-sh/shared-1.d: Fix relocation addend.
Index: ld/testsuite/ld-sh/shared-1.d
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-sh/shared-1.d,v
retrieving revision 1.3
diff -u -p -r1.3 shared-1.d
--- ld/testsuite/ld-sh/shared-1.d 2002/02/02 02:21:33 1.3
+++ ld/testsuite/ld-sh/shared-1.d 2002/02/11 05:35:24
@@ -13,7 +13,7 @@
Relocation section '\.rela\.text' at offset 0x328 contains 1 entries:
Offset Info Type Symbol's Value Symbol's Name Addend
-0000033c 000000a5 R_SH_RELATIVE 00000344
+0000033c 000000a5 R_SH_RELATIVE 00000340
Hex dump of section '\.rela\.text':
0x00000328 00000340 000000a5 0000033c .*
--
Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist Professional serial bug killer