This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
[PATCH] Warning roundup - opcodes/
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: binutils at sources dot redhat dot com
- Date: Sun, 10 Feb 2002 14:06:37 -0500
- Subject: [PATCH] Warning roundup - opcodes/
Committed as obvious, missing prototypes in cgen-dis.c.
There are more warnings in the opcodes directory - in fact, almost all the
remaining warnings I could find except for the ones I mentioned in BFD.
They are all in CGEN generated files; missing prototypes, unused
variables, and bad initializers. The initializers in particular are
annoying as they initialize unions, which I don't know a portable way to do.
I'm just leaving them all alone.
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
2002-02-10 Daniel Jacobowitz <drow@mvista.com>
* cgen-dis.c: Add prototypes for count_decodable_bits
and add_insn_to_hash_chain.
Index: opcodes/cgen-dis.c
===================================================================
RCS file: /cvs/src/src/opcodes/cgen-dis.c,v
retrieving revision 1.6
diff -u -p -r1.6 cgen-dis.c
--- cgen-dis.c 2001/11/14 20:07:27 1.6
+++ cgen-dis.c 2002/02/10 19:02:07
@@ -1,6 +1,6 @@
/* CGEN generic disassembler support code.
- Copyright 1996, 1997, 1998, 1999, 2000, 2001
+ Copyright 1996, 1997, 1998, 1999, 2000, 2001, 2002
Free Software Foundation, Inc.
This file is part of the GNU Binutils and GDB, the GNU debugger.
@@ -30,6 +30,11 @@
static CGEN_INSN_LIST * hash_insn_array PARAMS ((CGEN_CPU_DESC, const CGEN_INSN *, int, int, CGEN_INSN_LIST **, CGEN_INSN_LIST *));
static CGEN_INSN_LIST * hash_insn_list PARAMS ((CGEN_CPU_DESC, const CGEN_INSN_LIST *, CGEN_INSN_LIST **, CGEN_INSN_LIST *));
static void build_dis_hash_table PARAMS ((CGEN_CPU_DESC));
+static int count_decodable_bits PARAMS ((const CGEN_INSN *));
+static void add_insn_to_hash_chain PARAMS ((CGEN_INSN_LIST *,
+ const CGEN_INSN *,
+ CGEN_INSN_LIST **,
+ unsigned int));
/* Return the number of decodable bits in this insn. */
static int