This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [patch] binutils current: libiberty/configure and --with-build-subdir
These changes seem wrong to me. The point of them is to avoid trying
to auto-detect certain things because we're building a target library,
but for the build libiberty we are guaranteed to have a working
toolchain and we can safely autodetect everything.
> @@ -217,7 +222,7 @@ fi
>
> setobjs=
> CHECK=
> -if test -n "${with_target_subdir}"; then
> +if test -n "${with_build_subdir}" || test -n "${with_target_subdir}"; then
>
> # We are being configured as a target library. AC_REPLACE_FUNCS
> # may not work correctly, because the compiler may not be able to
> @@ -319,7 +324,7 @@ if test -z "${setobjs}"; then
>
> # DJ - only if we're *building* cygwin, not just building *with* cygwin
>
> - if test -n "${with_target_subdir}"
> + if test -n "${with_build_subdir}" || test -n "${with_target_subdir}"
> then
> funcs="`echo $funcs | sed -e 's/random//'`"
> LIBOBJS="$LIBOBJS random.o"
> @@ -406,7 +411,7 @@ AC_SUBST(INSTALL_DEST)
> AC_OUTPUT(Makefile testsuite/Makefile,
> [test -z "$CONFIG_HEADERS" || echo timestamp > stamp-h
> if test -n "$CONFIG_FILES"; then
> - if test -n "${with_target_subdir}"; then
> + if test -n "${with_build_subdir}" || test -n "${with_target_subdir}"; then
> # FIXME: We shouldn't need to set ac_file
> ac_file=Makefile
> . ${libiberty_topdir}/config-ml.in
> @@ -415,6 +420,7 @@ fi],
> srcdir=${srcdir}
> host=${host}
> target=${target}
> +with_build_subdir=${with_build_subdir}
> with_target_subdir=${with_target_subdir}
> with_multisubdir=${with_multisubdir}
> ac_configure_args="--enable-multilib ${ac_configure_args}"
>