This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: support for xstormy16
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Geoffrey Keating <geoffk at cygnus dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Sat, 8 Dec 2001 12:29:28 +1030
- Subject: Re: support for xstormy16
- References: <200112072237.fB7MbrL29154@thief.cygnus.com>
On Fri, Dec 07, 2001 at 02:37:53PM -0800, Geoffrey Keating wrote:
>
> This adds support for the Sanyo Xstormy16 CPU core. It shouldn't
> affect any other target.
OK, with some notes below.
> +static reloc_howto_type *
> +xstormy16_reloc_type_lookup (abfd, code)
> + bfd * abfd ATTRIBUTE_UNUSED;
> + bfd_reloc_code_real_type code;
> +{
> + unsigned int i;
> +
> + for (i = sizeof (xstormy16_reloc_map) / sizeof (xstormy16_reloc_map[0]);
> + --i;)
i-- as otherwise you don't check the first table entry (even though it
is only .._NONE).
> +static boolean
> +xstormy16_elf_relocate_section (output_bfd, info, input_bfd, input_section,
I don't see any support for SEC_MERGE here. Please take a look at
Jakub's recent changes, and consider adding a little more code.
> +++ ld/scripttempl/xstormy16.sc Fri Dec 7 14:26:58 2001
It's a shame you can't use elf.sc, as proliferation of scripts leads to
maintenance problems. How about adding a few more shell vars in elf.sc
to control the MEMORY stuff you need? I'm not too fussed either way on
this point.
Alan