This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
[PATCH] Use 'M' and 'S' in section string instead of 'm' and 's' (take 2)
On Tue, Sep 11, 2001 at 09:55:48AM +0930, Alan Modra wrote:
> On Mon, Sep 10, 2001 at 10:43:35PM +0200, Jakub Jelinek wrote:
> > Ok to commit or should I keep the 'm' compatibility support as RH specific
> > patch (where gcc uses "am" and "ams" for a few months now)?
>
> I wouldn't worry about backwards compatibility. Your string merge feature
> is new enough that people using it should expect some instability.
I'll keep the compatibility stuff as RH specific patch for a while.
Ok to commit?
2001-09-11 Jakub Jelinek <jakub@redhat.com>
* config/obj-elf.c (obj_elf_parse_section_letters): Use 'M' instead
of 'm', 'S' instead of 's'. Update bad_msg.
* config/tc-ppc.c (ppc_section_letter): Update bad_msg.
* config/tc-i370.c (i370_sectioN_letter): Update bad_msg.
--- gas/config/obj-elf.c.jj Thu Aug 23 13:06:46 2001
+++ gas/config/obj-elf.c Tue Sep 11 11:42:48 2001
@@ -750,15 +750,15 @@ obj_elf_parse_section_letters (str, len)
case 'x':
attr |= SHF_EXECINSTR;
break;
- case 'm':
+ case 'M':
attr |= SHF_MERGE;
break;
- case 's':
+ case 'S':
attr |= SHF_STRINGS;
break;
default:
{
- char *bad_msg = _("Unrecognized .section attribute: want a,m,s,w,x");
+ char *bad_msg = _("Unrecognized .section attribute: want a,w,x,M,S");
#ifdef md_elf_section_letter
int md_attr = md_elf_section_letter (*str, &bad_msg);
if (md_attr >= 0)
--- gas/config/tc-ppc.c.jj Fri Sep 7 20:46:44 2001
+++ gas/config/tc-ppc.c Tue Sep 11 11:43:28 2001
@@ -2440,7 +2440,7 @@ ppc_section_letter (letter, ptr_msg)
if (letter == 'e')
return SHF_EXCLUDE;
- *ptr_msg = _("Bad .section directive: want a,w,x,e in string");
+ *ptr_msg = _("Bad .section directive: want a,e,w,x,M,S in string");
return 0;
}
--- gas/config/tc-i370.c.jj Mon Aug 13 13:05:37 2001
+++ gas/config/tc-i370.c Tue Sep 11 11:43:47 2001
@@ -2462,7 +2462,7 @@ i370_section_letter (letter, ptr_msg)
if (letter == 'e')
return SHF_EXCLUDE;
- *ptr_msg = "Bad .section directive: want a,w,x,e in string";
+ *ptr_msg = "Bad .section directive: want a,e,w,x,M,S in string";
return 0;
}
Jakub